Rename ClickEvent to MouseEvent and add type() to Event #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuripourre
changed the title
|
I've merged your changes to the master branch. Thank you for your contribution! |
|
@mirkosertic Thank you so much! |
mirkosertic
pushed a commit
that referenced
this pull request
Nov 8, 2021
* Rename ClickEvent to MouseEvent * Add getType method to Event * Rename getType() to type() to follow Bytecoder's standard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename ClickEvent to MouseEvent, following this convention/specification: https://developer.mozilla.org/en-US/docs/Web/API/MouseEvent
Also, following the same specification, adds type() to Event (it is not ideal but is useful to handle multiple events with a single EventListener).