Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressing the Homepage-button closes all open tabs #23

Closed
1 task done
KevinvdT opened this issue Oct 15, 2022 · 2 comments
Closed
1 task done

Pressing the Homepage-button closes all open tabs #23

KevinvdT opened this issue Oct 15, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@KevinvdT
Copy link

KevinvdT commented Oct 15, 2022

Summary

Pressing the Home button closes all open tabs, then opening a new tab with the home page

Steps to reproduce

Foremost, thanks a lot for developing this plugin. ☺️

Current behavior

The new Obisidian update having brought tab support. When pressing the Homepage-button, all open tabs are closed and a new tab with the homepage is opened .

Expected behavior (I think)

When pressing the Homepage-button, the homepage opens in the current active tab. All other open tabs are uneffected.

I may be wrong with the expected behavior, but it seems more logical to me. If it is not, then an option to have this behavior would be appreciated.

Removing src/main.js line 404 seems to fix the issue for me, but may produce undesired behavior during startup of Obisidian.

this.app.workspace.detachLeavesOfType("markdown");

Obsidian info

No community plugins besides obisidian-homepage enabled.

Obsidian version

1.0.0

Checklist

  • I updated to the latest version of the plugin.
@KevinvdT KevinvdT added the bug Something isn't working label Oct 15, 2022
@mirnovov
Copy link
Owner

This is intentional behaviour, but you can change this via the “Opening mode” in settings. Right now there’s not a separate option for startup versus clicking the button, but I can add this.

@mirnovov
Copy link
Owner

I've added the feature in 1418563

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants