Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update loading_bar.js #5

Closed
wants to merge 12 commits into from
Closed

Update loading_bar.js #5

wants to merge 12 commits into from

Conversation

ipostol
Copy link

@ipostol ipostol commented Jun 27, 2016

add more settings to props

@ipostol
Copy link
Author

ipostol commented Jun 27, 2016

please add props for customize loading-bar speed etc..

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling d9e120e on ipostol:patch-2 into af3ec66 on mironov:master.

@mironov
Copy link
Owner

mironov commented Jun 28, 2016

@ipostol Good idea!
Please add a spec for the change and I'll merge it.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 0dc0b41 on ipostol:patch-2 into af3ec66 on mironov:master.

@ipostol
Copy link
Author

ipostol commented Jun 28, 2016

Sorry for many build fails, It was too lazy to clone repository :)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling b20d3a4 on ipostol:patch-2 into af3ec66 on mironov:master.

@mironov
Copy link
Owner

mironov commented Jul 3, 2016

@ipostol Hey, I've incorporated your changes in 0c3dc25 along with additional tests.
Thanks for the pull request!

@mironov mironov closed this Jul 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants