Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leaks caused by multiple start calls #87

Closed
wants to merge 2 commits into from

Conversation

art5255
Copy link

@art5255 art5255 commented Apr 9, 2019

if start called multiple times should clear previous interval to avoid memory leak

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.04%) to 98.958% when pulling 264e698 on art5255:master into 6632b49 on mironov:master.

@mironov
Copy link
Owner

mironov commented Apr 20, 2019

@art5255 Thank you for the PR. Any idea of how several sequential calls of start() could happen? I wonder if a test can be written for the case.

@mironov
Copy link
Owner

mironov commented Oct 20, 2019

I think I fixed a possible case when start() could be called twice resulting in leaking progressInterval in 832727c
I'm going to close this PR for now.

Feel free to rebase and reopen it if the issue still persists in >= v4.5.0

@mironov mironov closed this Oct 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants