Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hc-changepass #227

Closed
wants to merge 1 commit into from
Closed

hc-changepass #227

wants to merge 1 commit into from

Conversation

the-j0k3r
Copy link

No description provided.

@kernel-panic69
Copy link

This should be changed so it follows the wiki, perhaps. Broadcom is Client Bridge and there are two separate wikis for this mode because the procedure has notable differences. Just my thoughts.

wl_basic.clientRelayd="Client Bridged";

@the-j0k3r
Copy link
Author

the-j0k3r commented Jun 11, 2022

This use to be and has always been until now

wl_basic.clientRelayd="Client Bridge (Routed)";

it was changed to follow the logic implied that this is somehow routed above all.

wl_basic.clientRelayd="Routed Client Bridge";

The Wiki is the wiki... I can revert to old but never to just the suggested since it doesn't Imply Routed

we have another string that is wl_basic.clientBridge="Client Bridge"; idk what the wiki says or what it referrs to, but either way if the string isnt target dependant the it alwasy implied routing no matter platform.

I can revert but need to be what it implies no matter the wording.

@the-j0k3r the-j0k3r closed this Jun 11, 2022
@kernel-panic69
Copy link

Client Bridge is Broadcom. Client Bridge (routed) is all others that support the functionality. I have no control over who created wiki pages, and I cannot delete pages in the wiki to match code changes. It is what it is.

@the-j0k3r
Copy link
Author

the-j0k3r commented Jun 11, 2022

Makes no sense to me to show that string if the router doesn't support that functionality, end of story, Wiki wise, idk I bet it was writen before the last ice age.

On the old string, enclosing something in parenthesis specifically means (implied distinction) it doesnt mean that its optional or may not be available.

Ive reverted it to what it use to be and until someone provides a proper fix with related strings only displayed on routers that support it, it will remain.

@the-j0k3r
Copy link
Author

the-j0k3r commented Jun 12, 2022

The difference between client bridge and client bridge routed is the way its faked

On some devices both are offered routed and standard client bridge
this is why there is the hind behind how its done

then you have 2 client bridge entries on some devices

client bridge works as arp proxy relay. client bridge routed is in fact a routing hack to simulate a bridge
both are not real bridges. only wds can offer this
maybe we can rename client to "station"
because of wds station
yes station is in fact more accurate than client

And that is the information I have from BS.

The strings will be renamed from client to station because it is a wds station functionality as it was explained to me and what BS is doing to these strings, so whatever wiki now says it will be obsolete when that is done.

The naming of the strings was to force them to show one after the other and no other reason, which ordering is now gonna be fixed see commit below.

Related https://svn.dd-wrt.com/changeset/49156 and will likely be other commits attached to this for strings naming is my guess.

@kernel-panic69
Copy link

Thanks, I already knew all of that about the bridge modes. I was also aware of the rest of that. Enjoy your Sunday.

@the-j0k3r
Copy link
Author

https://svn.dd-wrt.com/changeset/49155 wiki now fully obsolete where these strings are concerned. BS decided these are actually correct after our discussion about your report here.

@kernel-panic69
Copy link

I stumbled across this post in the forum the other day. It rings true in respect to the wiki as well as the general attitude of certain people, myself included. I am fine with that changeset, never said I wasn't. This wasn't a report, it was a comment. You should probably quit asking for input if you are going to wind up responding this way. It shuns would-be contributors.

https://forum.dd-wrt.com/phpBB2/viewtopic.php?t=283892

The wikis will never be perfect or in line with development with too many fingers in the pot and edit access not being enough to remove pages and redirects and rename pages without redirects. It would take me a year to get it in line with current state of affairs and remove all the irrelevant information.

@the-j0k3r
Copy link
Author

the-j0k3r commented Jun 13, 2022

Just letting you know of the changeset since you made the original query here. this is the last time I indulge you, fully unwarranted ala KP attitude as always.

Unsubscribed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants