Themes update

[the-j0k3r]

@BrainSlayer here is some more bits and pieces

please review

[BrainSlayer]

websWrite(wp, "<option value="duo_cocoa" %s>Duo Cocoa\n", nvram_match("stylus", "dracula") ? "selected="selected"" : "");

i mean you see whats wrong on that line

[BrainSlayer]

i merged it and fixed the small misstake

[the-j0k3r]

Missing the last name ("stylus", "dracula") -> ("stylus", "duo_cocoa")

yep copy and paste monster strikes again.

Thx...

FYI you check my sig on forums and try it out f you like

[the-j0k3r]

@BrainSlayer, Im hoping these changes in classic themes will reach the help/about menu when classic dark mode is enabled,
same for the inspired stuff.

It never made sense to me why classic styles never touched those areas, and increasing specificity is one way to get there, unless CGI magic is involved.

Then from here its the other 99 which Im unsure yet how to get it done.

Thanks, I hope you enjoy the forums/trac bits. Limitations apply to admin/mod areas in both. And I wouldn't try to do the same (youre welcome to try), it will likely conk out somewhere due to way the default stuff in phpBB2 and trac is more hacky than mine. So it will likely go poof and borked everywhere,

[the-j0k3r]

@BrainSlayer also there are a couple of fixes for the forums and trac that should be included in production, like the images flying out of bounds.

For forums its

  .attachtable[width="95%"] img {
    max-width: 95%
  }

for trac its

  .comment p a[href*='/attachment/'] img {
    max-width: 99%
  }

Those should be handled in all browsers including mobile and removes restrictions on what images dimensions can be uploaded / attached.

Famous last words ;)

[BrainSlayer]

there is cgi magic involved. the page header which is cgi generated does not include the standard stylesheet. thats all. but the same applies to inspired themes. should i include it there?

[BrainSlayer]

trac? trac is not modified. there is nothing out of bounds. for the forum i dont know where to start. i did not do the styles there, just the core code based on phpbb

[the-j0k3r]

there is cgi magic involved. the page header which is cgi generated does not include the standard stylesheet. thats all. but the same applies to inspired themes. should i include it there?

Well should yes, all areas should be styleable via themes, no matter who they are.

trac? trac is not modified.

No but, yet its still suffers from that bug. just look at https://svn.dd-wrt.com/ticket/7457#comment:14 for instance

for the forum i dont know where to start

Well... this should be OK anywhere in some stylesheet which seem to be generated somewhere with these contents.

td.attachrow		{ font: normal 11px Verdana, Arial, Helvetica, sans-serif; color : #000000; border-color : #000000; }
td.attachheader     { font: normal 11px Verdana, Arial, Helvetica, sans-serif; color : #000000; border-color : #000000; background-color: #D1D7DC; }
table.attachtable	{ font: normal 12px Verdana, Arial, Helvetica, sans-serif; color : #000000; border-color : #000000;	border-collapse : collapse; }

In browser that stylesheet gets pushed some 4 times, why IDK

But I guess the default stylessheetshould also be good.

[BrainSlayer]

which bug? i dont see anything wrong

[kernel-panic69]

The "bug" or "issue" in Trac is really prevalent in this ticket: https://svn.dd-wrt.com/ticket/6300 The screenshot in one of the comments is well over-sized and skews the page formatting. People must think we all have 32-50" monitors or bad eyes.

[BrainSlayer]

changed trac now with your style edit

[kernel-panic69]

As I just commented and now it's fixed! Thank you, sir!

[BrainSlayer]

forum is now fixed too

[the-j0k3r]

The "bug" or "issue" in Trac is really prevalent in this ticket: https://svn.dd-wrt.com/ticket/6300 The screenshot in one of the comments is well over-sized and skews the page formatting. People must think we all have 32-50" monitors or bad eyes.

Neither is actually true, assuming such is unrealistic. The default CSS in both these cases is bugged. If the bugs never existed you wouldn't notice the issue until downloading and opening the attachments locally, or opening the attachments directly.

In any case, as long as we aren't aiming to support outdated browsers like internet explorer and such the hacks should work across platforms.

See with my stuff enabled.

And if they dont and some special handling is required for some older/edge case, it cant be worst than the previously existing issues.

Famous last words =)

forum is now fixed too

Great so if after some acid tests we shall see if the current forum rules/restrictions regarding image resolution uploads have a reason to exist.

I would restrict in any case the amount of MB per attachment. If someone still uses jpeg/jpg or BMP etc.

[kernel-panic69]

Yes, now both are fixed; I forgot to disable tampermonkey for the forum and it was still acting stupid like the fix wasn't present, but on another machine not even logged in or using tampermonkey, it was fine. Not sure why tampermonkey caused it to balk, but all is good to go now.

Well, if the rules no longer apply, I cannot do anything about it; angry mob and pitchforks eyeroll

[BrainSlayer]

there might be a good reason for some resolution limitations. not everyone has a fibre line at home. upload size is restricted anyway. but the attachment code is generic. it restricts upload sizes. but firmware images are sometimes very big. the display code later detects if a upload can be previewed as jpg image or not if its a binary. so no, i cannot restrict the image upload size

[BrainSlayer]

btw. its not about the monitor size, its about resolution. okay i have a 4k monitor in my laptop.

[kernel-panic69]

I was making a vain attempt at humor - "size matters" ^_^, but resolution / size ... anyway, I'm just glad that it's been resolved, finally.

[the-j0k3r]

Needs more acid tests across platforms and devices, and only time and willing testers to go out of their normal usage will be able to tell.

As for actual reasons for resolution limitations, since all custom stuff exist in forums, it cant be hard to get a on the fly resising after the fact, no matter what boards are running.

Point being, fibre or not, asking people to resize anything should be done at the very least when trying to do it. i.e. I upload something really out of any reasonable realm liken a 40Megapixel photo and Im told by interface to get realistic, because the reality is less than .01% have 32'/50' screens.
There is good user UX and not so half decent UX. Wherever technology can solve its own issues we should let it.

I do have bad eyes and 27' 4K screen stuck on 1440p because 4k on such small screen is minuscule And I dont use tech to play games. So max for me is 27' and max 2560x1440p, anything higher its not good at all.

[BrainSlayer]

downscaling by html code is not a solution for upload sizes

[the-j0k3r]

downscaling by html code is not a solution for upload sizes

Doesn't have to be HTML, its just has to plug a script into the function. Essentially custom handling. Im not familiar with PHP in any case, but Im sure some hack is possible using javascript or other scripting language in case ppl have javascript disabled.

[kernel-panic69]

24", 27" and 32" monitors; and the antique MBP is a 17". This is at my primary desk. I don't have anything over 21" in the shop area. Even on the larger monitors, the forum page format would get all fscked up by image attachments. I think the solution in place works until it's proven not to work.

[the-j0k3r]

@BrainSlayer re https://svn.dd-wrt.com/changeset/47493 if it needs be the stylesheet can be separated and called in rather than hardcoding it. Similar to the error handling bits.

[the-j0k3r]

@BrainSlayer also dont forget classic themes should be able to style these about/help as well not just new

Im sure theres other dialogs/popups here and there, I just cant do all of them in one go.

[BrainSlayer]

sure. but about page needs to be rewritten first to fit to the classic style

[BrainSlayer]

and no there arent popups without classic style and themes. the only exception is the mac oid display since its stored on a external server

[the-j0k3r]

sure. but about page needs to be rewritten first to fit to the classic style

Re-written? Speaking of re-writing the about page....

Remember those entries that I made into a pretty table which explain the the different distributions and you said thats old stuff for 2006 routers models?

Wouldn't that various distributions/features information actually belong somewhere else rather than the about page and just be linked in about page say to wiki?

For my money, and to make this about page a succinct page, perhaps it would make more sense to add the distribution/features type for the router in use if applicable also autogenerated an d filling in on the about page, so each different router would show the most pertinent info to its build.

This current router info would be shunted into the relevant parts of the table, with the rest of the current about page being just reformatted like the translators acknowledgements and such.

What do you think?

Regarding the help pages... I find that most of the features present on my router for instance dont all have corresponding explanations, somehow this information has to exist somewhere.

I haven't looked into the code areas for this but since a great deal is generated already per router, and instead of duplicating this info but rather scraped from wiki or somewhere and reformatted to fit the current design and router help pages generated per router/features on compile time then populated there.

Does any of this make sense and or something to be improved in future? Maybe someone who is an avid wiki person could help with these areas.

[BrainSlayer]

no .i just said that the about page was written without any css style in mind which is used by dd-wrt. it never used the stylesheet. a reason might be that some of the dd-wrt styles are not compatible with it
and yes the content of the about page is also bogus and bullshit. nobody cares about these old distributions. about should contain the various required copy right notices. maybe build informations and other usefull things, but not unrelated text
usually i can bring in some cgi code to display the included programs and packages in the build. dont know

[the-j0k3r]

and yes the content of the about page is also bogus and bullshit. nobody cares about these old distributions. about should contain the various required copy right notices. maybe build informations and other usefull things, but not unrelated text

Sure Im all for this, hence why I suggested this would probably would be best auto generated per router/feature set.

Same with help page entries that are missing for half the features

as for stylesheet for about/help, dont worry about the umpeeten built in themes, the only one that needs to support that is fresh-dark.css for now. (when users select dark toggle on classic themes or the inspired themes.)

this is why already the changes pushed in this round. It should work as long as both help page and about page css is exposed to being themed on the fly via fresh-dark.css and inspired themes.

More to come in later, Ide love to rip them all apart and redo the lot classic theme, but theres not enough hours in a day.