Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed typos #33

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Fixed typos #33

merged 2 commits into from
Oct 26, 2023

Conversation

mklomp
Copy link
Contributor

@mklomp mklomp commented Oct 23, 2023 •
edited

Fixes #26

@mklomp mklomp requested a review from ArendJan October 23, 2023 12:57
@ArendJan
Copy link
Contributor

ArendJan commented Oct 24, 2023 •
edited

Found a typo in https://github.com/mirte-robot/mirte-web-interface/blob/a1ee1dea90adabfe8f8e140bc55b151bf92d0b4d/vue-frontend/locales/nl.json#L82C25-L82C31

Duplicate key in https://github.com/mirte-robot/mirte-web-interface/blob/a1ee1dea90adabfe8f8e140bc55b151bf92d0b4d/vue-frontend/locales/en.json#L4C34-L4C34

Duplicate also in the other file

ArendJan
ArendJan requested changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@ArendJan ArendJan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay, it feels like the Dutch translations need a comma between "... lukt komt ... ", "... komt wordt ... " and "... gelukt is kan ..."

Also see my other comment

@mklomp mklomp requested a review from ArendJan October 26, 2023 08:40
ArendJan
ArendJan approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@ArendJan ArendJan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ArendJan ArendJan merged commit f07e633 into mirte-robot:main Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArendJan ArendJan ArendJan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

There are some typo's in the network UI (both Dutch and English)
2 participants
@mklomp @ArendJan