Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent contextmenu on the control arrows #35

Conversation

ArendJan
Copy link
Contributor

@ArendJan ArendJan commented Oct 24, 2023

Closes #31

  • Prevents right-click on the control arrow buttons, but triggers the normal click action.
  • Checked on a chromebook and added that all contextbutton clicks are caught in the control area
  • Added overscroll-behavior-x: none; to html tag to disable forward / backward swipes on touch-enabled devices. This was a problem when using the sliders (motor/servo)

@ArendJan ArendJan requested a review from mklomp October 24, 2023 08:46
@ArendJan ArendJan self-assigned this Oct 24, 2023
@ArendJan ArendJan added the enhancement New feature or request label Oct 24, 2023
@ArendJan ArendJan added this to the 0.1 milestone Oct 24, 2023
@ArendJan
Copy link
Contributor Author

I've also changed the behaviour of the motor and servo sliders. Previously you needed to release the knob for the motor/servo to update, now it will update while sliding to make it easier and less chance of setting a servo at a too high angle as you see it moving while moving the slider

@ArendJan ArendJan marked this pull request as ready for review October 25, 2023 14:24
Copy link
Contributor

@mklomp mklomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice additions!

@mklomp mklomp merged commit 479b0f9 into mirte-robot:main Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Disable context menu (right click) on the arrow buttons
2 participants