Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing dependency to pyproject.toml #219

Conversation

danieledwardgeorgehitchcock
Copy link

@danieledwardgeorgehitchcock danieledwardgeorgehitchcock commented Sep 20, 2023

When running mypy against the generated client in a fresh environment, the following warnings are raised:

graphql_client\async_base_client.py:19: error: Cannot find implementation or library stub for module named "websockets.client"  [import]
graphql_client\async_base_client.py:19: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
graphql_client\async_base_client.py:20: error: Cannot find implementation or library stub for module named "websockets.typing"  [import]

The GitHub test flow is set to ignore import errors due to false positives in other libraries however, this is explicitly required in async_base_client.py

I have added the missing dependency to the pyproject.toml, have tested locally and this error then disappears when included.

Copy link
Contributor

@mat-sop mat-sop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have websockets~=11.0 as an optional subscriptions dependency. We should modify async_base_client.py to pass mypy --strict even without installed websockets.

@rafalp
Copy link
Contributor

rafalp commented Dec 4, 2023

Superseded by #246

@rafalp rafalp closed this Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants