Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass kwargs to base client`s execute and execute_ws methods #232

Merged
merged 7 commits into from
Nov 2, 2023
Merged

Pass kwargs to base client`s execute and execute_ws methods #232

merged 7 commits into from
Nov 2, 2023

Conversation

mat-sop
Copy link
Contributor

@mat-sop mat-sop commented Oct 31, 2023

This pr changed the generated client's methods to accept and pass **kwargs to base client's execute and execute_ws methods. Default base clients pass it to http_client.post and ws_connect methods.

resolves #228

@mat-sop mat-sop self-assigned this Oct 31, 2023
@mat-sop mat-sop requested a review from rafalp October 31, 2023 13:04
@mat-sop mat-sop changed the title Execute kwargs Pass kwargs to base client`s execute and execute_ws methods Oct 31, 2023
@mat-sop mat-sop merged commit 913dcdf into main Nov 2, 2023
3 checks passed
@mat-sop mat-sop deleted the execute_kwargs branch November 2, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafalp rafalp rafalp approved these changes

Assignees

@mat-sop mat-sop

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: header overload in client on call
2 participants
@mat-sop @rafalp