Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Operations plugin #234

Merged
merged 13 commits into from
Nov 8, 2023
Merged

Operations plugin #234

merged 13 commits into from
Nov 8, 2023

Conversation

mat-sop
Copy link
Contributor

@mat-sop mat-sop commented Nov 8, 2023

This pr:

  • adds operation_definition argument to generate_client_method plugin hook
  • adds OperationsPlugin

resolves #230

@mat-sop mat-sop self-assigned this Nov 8, 2023
@mat-sop mat-sop requested a review from rafalp November 8, 2023 14:28
rafalp
rafalp approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@rafalp rafalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets rename the plugin to ExtractOperationsPlugin. I've also left couple suggestions to readme and changelog.

CHANGELOG.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
ariadne_codegen/contrib/operations.py Outdated Show resolved Hide resolved
rafalp
rafalp suggested changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@rafalp rafalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more suggestions:

  • Operation variables as GET_A_GQL instead of getA_GQL
  • Rename plugin's file to extract_operations

@mat-sop mat-sop requested a review from rafalp November 8, 2023 16:02
@mat-sop mat-sop merged commit 9c0041b into main Nov 8, 2023
3 checks passed
@mat-sop mat-sop deleted the operations_plugin branch November 8, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafalp rafalp rafalp approved these changes

Assignees

@mat-sop mat-sop

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: expose the gql query definitions used by the client.
2 participants
@mat-sop @rafalp