Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate subdirectory for result types #261

Closed
wants to merge 3 commits into from

Conversation

alzex3
Copy link
Contributor

@alzex3 alzex3 commented Jan 13, 2024

Dear Maintainers,

I am excited to propose an enhancement to library, which I believe will improve its usability.

Issue Addressed:
Currently, the library's hundreds of modules, including client enums, inputs, fragments, and the client itself, are housed in a single package directory. More information is available in the issue.

Proposed Change:
To address this, I have implemented a feature that allows result types to be saved into a separate subdirectory. This feature is disabled by default and have no breaking changes for current users.

Implementation Details:

  1. Direct Integration into Client Generator: Recognizing the limitation of being unable to save result types into a different directory without modifying package module, I've directly incorporated the necessary logic into the client generator.
  2. New Configuration Option: A new parameter, result_types_directory_name, has been introduced. Users can specify the name of the subdirectory for result types using this parameter. If this parameter is omitted or left empty, the result types will be stored in the package root, maintaining the existing behavior.
  3. Compatibility with Current Plugins: This feature has been tested to be fully compatible with all current plugins,

Thank you for your time and for considering this contribution to the project. If you have any suggestions or remarks about the code changes, please feel free to comment here, and I will do my best to find a better solution.

Best regards,
Alex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant