Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore model_rebuild calls to top level fragments #267

Merged
merged 10 commits into from
Jan 25, 2024
Merged

Restore model_rebuild calls to top level fragments #267

merged 10 commits into from
Jan 25, 2024

Conversation

bombsimon
Copy link
Contributor

  • Restore model_rebuild calls to top level fragments
  • Update tests
  • Update changelog
  • Update example
  • Fix pylint violation
  • Add test to ensure models are rebuilt properly

Superseds #258

@bombsimon bombsimon mentioned this pull request Jan 23, 2024
Closed
rafalp
rafalp suggested changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@rafalp rafalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but we could improve the test.

tests/main/test_model_rebuild_validation.py Outdated Show resolved Hide resolved
tests/main/test_model_rebuild_validation.py Outdated Show resolved Hide resolved
tests/main/test_model_rebuild_validation.py Outdated Show resolved Hide resolved
tests/main/test_model_rebuild_validation.py Outdated Show resolved Hide resolved
rafalp
rafalp suggested changes Jan 24, 2024
View reviewed changes
tests/main/test_model_rebuild_validation.py Outdated Show resolved Hide resolved
tests/main/test_model_rebuild_validation.py Outdated Show resolved Hide resolved
tests/main/test_model_rebuild_validation.py Outdated Show resolved Hide resolved
bombsimon and others added 2 commits January 24, 2024 13:50
@bombsimon @rafalp
Apply suggestions from code review
5aa4fad 
Co-authored-by: Rafał Pitoń <rafio.xudb@gmail.com>
@bombsimon
Rename field_a fixture
5d6e3f8
@rafalp rafalp merged commit 9edc90b into mirumee:main Jan 25, 2024
4 checks passed
@rafalp
Copy link
Contributor

rafalp commented Jan 25, 2024

Excellent, thank you!

@rafalp rafalp mentioned this pull request Jan 25, 2024
Closed
@bombsimon bombsimon deleted the nested_fragments branch February 3, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafalp rafalp rafalp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bombsimon @rafalp @mat-sop