add model_rebuild_calls for result_types.py #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafalp
reviewed
Feb 23, 2024
There was a problem hiding this comment.
Whole problem that #241 sought to address was that calling model_rebuild for models that don't require it killed client performance.
I am seeing in tests changes that models that don't have forward references are now having model_rebuild calls which will bring us back to square one.
rafalp
suggested changes
Feb 23, 2024
rafalp
suggested changes
Feb 26, 2024
rafalp
suggested changes
Feb 26, 2024
rafalp
suggested changes
Feb 26, 2024
.../clients/fragments_on_abstract_types/expected_client/query_with_fragment_on_sub_interface.py
Outdated
Show resolved
Hide resolved
rafalp
reviewed
Feb 27, 2024
rafalp
reviewed
Feb 27, 2024
rafalp
approved these changes
Feb 27, 2024
bombsimon
added a commit
to bombsimon/ariadne-codegen
that referenced
this pull request
Mar 6, 2024
Followup from mirumee#278 and mirumee#276. We added back support to call `model_rebuild` when needed for result types but didn't add it for input types. Since input types can also require model rebuild when containing nested fields we need to call `include_model_rebuild` for these types as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem #276 , which emerged with the introduction of #241 , is resolved by this update.
It adds back
generate_method_callforresult_types.py.Fixes #276