Drop python2 #1474
Merged
Drop python2 #1474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1474 +/- ##
=========================================
Coverage ? 82.44%
=========================================
Files ? 131
Lines ? 5668
Branches ? 647
=========================================
Hits ? 4673
Misses ? 831
Partials ? 164
Continue to review full report at Codecov.
|
krzysztofwolski
requested changes
Dec 13, 2017
tests/test_emails.py
Outdated
| from django.conf import settings | ||
| import mock |
There was a problem hiding this comment.
Can we use Mock from unittest?
from unittest.mock import Mock
saleor/core/templatetags/shop.py
Outdated
| @@ -1,4 +1,3 @@ | |||
| from __future__ import unicode_literals | |||
| try: | |||
| from itertools import zip_longest | |||
There was a problem hiding this comment.
Catching import error no longer needed
|
Rebased on current master branch. |
maarcingebala
approved these changes
Dec 14, 2017
This removes Py2-specific features: * encoding declaration (Python 3 defaults to UTF-8) * future feature imports * u-prefixed unicode literals * six library
lampyjon
added a commit
to lampyjon/saleor
that referenced
this pull request
Dec 28, 2017
saleor#1474 should have included a documentation updated.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes Python 2-specific features:
__future__feature importsu-prefixed unicode literalssixlibrarytry/exceptmocklibrary as it's now part of the standard libraryFixes #1421
Pull Request Checklist
(Please keep this section. It will make maintainer's life easier.)
pycodestyle,pydocstyle,pylint.eslint.