New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop python2 #1474
Drop python2 #1474
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1474 +/- ##
=========================================
Coverage ? 82.44%
=========================================
Files ? 131
Lines ? 5668
Branches ? 647
=========================================
Hits ? 4673
Misses ? 831
Partials ? 164
Continue to review full report at Codecov.
|
tests/test_emails.py
Outdated
from django.conf import settings | ||
import mock |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use Mock from unittest?
from unittest.mock import Mock
saleor/core/templatetags/shop.py
Outdated
@@ -1,4 +1,3 @@ | |||
from __future__ import unicode_literals | |||
try: | |||
from itertools import zip_longest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Catching import error no longer needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Rebased on current master branch. |
This removes Py2-specific features: * encoding declaration (Python 3 defaults to UTF-8) * future feature imports * u-prefixed unicode literals * six library
saleor#1474 should have included a documentation updated.
This removes Python 2-specific features:
__future__
feature importsu
-prefixed unicode literalssix
librarytry
/except
mock
library as it's now part of the standard libraryFixes #1421
Pull Request Checklist
(Please keep this section. It will make maintainer's life easier.)
pycodestyle
,pydocstyle
,pylint
.eslint
.