Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a request history panel to the debug toolbar for easier Ajax debug #2271

Merged

Conversation

NyanKiyoshi
Copy link
Member

Hello!

This is a little edit that I think quite useful to debug and profile Ajax requests that I think could be useful to Saleor to have.

This PR adds a new panel to django-debug-toolbar which tracks the request history and kept the list updated, allowing us to to gain an easy access to Ajax requests.

Screenshots

Request list made on dashboard 2.0

SQL requests made on dashboard 2.0 on an Ajax request

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. The changes are tested.
  6. The code is documented (docstrings, project documentation).

@codecov
Copy link

codecov bot commented Jun 10, 2018

Codecov Report

Merging #2271 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2271   +/-   ##
=======================================
  Coverage   87.32%   87.32%           
=======================================
  Files         176      176           
  Lines        7872     7872           
  Branches      810      810           
=======================================
  Hits         6874     6874           
  Misses        756      756           
  Partials      242      242

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b16e8b8...cf6c3f9. Read the comment docs.

@maarcingebala maarcingebala merged commit a8a643c into saleor:master Jul 19, 2018
@NyanKiyoshi NyanKiyoshi deleted the django-debug/add-request-history branch July 19, 2018 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants