Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix schema after bulk mutations are added #3843

Merged
merged 2 commits into from
Mar 18, 2019

Conversation

jxltom
Copy link
Contributor

@jxltom jxltom commented Mar 18, 2019

It looks the schema in #3838 is incorrect, the bulk mutation should return count. This PR fixes this issue.

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. Database migration files are up to date.
  6. The changes are tested.
  7. The code is documented (docstrings, project documentation).
  8. GraphQL schema and type definitions are up to date.
  9. Changes are mentioned in the changelog.

@codecov
Copy link

codecov bot commented Mar 18, 2019

Codecov Report

Merging #3843 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3843   +/-   ##
=======================================
  Coverage   90.79%   90.79%           
=======================================
  Files         263      263           
  Lines       14142    14142           
  Branches     1412     1412           
=======================================
  Hits        12840    12840           
  Misses        894      894           
  Partials      408      408

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66f6628...20f522e. Read the comment docs.

@maarcingebala maarcingebala merged commit 37f6ad7 into saleor:master Mar 18, 2019
@jxltom jxltom deleted the update-schema branch March 20, 2019 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants