Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent user from changing his permissions and status #3922

Merged
merged 6 commits into from
Apr 4, 2019

Conversation

dominik-zeglen
Copy link
Contributor

@dominik-zeglen dominik-zeglen commented Apr 4, 2019

I want to merge this change because it prevents the user from harming himself :) Also adds pretty avatars.
Resolves #2966

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. Database migration files are up to date.
  6. The changes are tested.
  7. The code is documented (docstrings, project documentation).
  8. GraphQL schema and type definitions are up to date.
  9. Changes are mentioned in the changelog.

@codecov
Copy link

codecov bot commented Apr 4, 2019

Codecov Report

Merging #3922 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3922   +/-   ##
=======================================
  Coverage   90.58%   90.58%           
=======================================
  Files         266      266           
  Lines       14528    14528           
  Branches     1455     1455           
=======================================
  Hits        13160    13160           
  Misses        941      941           
  Partials      427      427

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f119681...0bf7450. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 4, 2019

Codecov Report

Merging #3922 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3922   +/-   ##
=======================================
  Coverage   90.58%   90.58%           
=======================================
  Files         266      266           
  Lines       14528    14528           
  Branches     1455     1455           
=======================================
  Hits        13160    13160           
  Misses        941      941           
  Partials      427      427

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f119681...0bf7450. Read the comment docs.

@maarcingebala maarcingebala merged commit c3ebf32 into master Apr 4, 2019
@maarcingebala maarcingebala deleted the fix-staff-error-displaying branch April 4, 2019 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants