-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MUI and take some care of Storybook #4115
Conversation
c4692e9
to
d7d12d6
Compare
Codecov Report
@@ Coverage Diff @@
## master #4115 +/- ##
==========================================
+ Coverage 91.51% 91.52% +0.01%
==========================================
Files 277 277
Lines 15083 15083
Branches 1479 1479
==========================================
+ Hits 13803 13805 +2
+ Misses 875 874 -1
+ Partials 405 404 -1
Continue to review full report at Codecov.
|
Oh cmon it's mostly snapshots! |
It doesn't really mater what it is. U know that equally I can just approve it because of amount of changes.... |
There's like 500 LOC that really do need to be read. The rest are snapshots and one-line changes like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not be using Checkbox
component's onClick
property before and I don't think we should be using it now. Please at least implement an onChange
property so we can gradually fix our code.
3f2df3f
to
b2a2201
Compare
I want to merge this change because it adds new inputs and improves storybook a bit.
Screenshots
Pull Request Checklist