Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate localized field in Money type #4952

Merged
merged 3 commits into from
Nov 7, 2019

Conversation

IKarbowiak
Copy link
Member

@IKarbowiak IKarbowiak commented Nov 7, 2019

Set 'localized' field in the Money type as deprecated - it's useless. Price formatting according to the current locale will be handled by the frontend client.

Closes #4934

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. Database migration files are up to date.
  6. The changes are tested.
  7. GraphQL schema and type definitions are up to date.
  8. Changes are mentioned in the changelog.

@IKarbowiak IKarbowiak added the graphql Issues related to the GraphQL API label Nov 7, 2019
@IKarbowiak IKarbowiak self-assigned this Nov 7, 2019
@codecov
Copy link

codecov bot commented Nov 7, 2019

Codecov Report

Merging #4952 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4952   +/-   ##
=======================================
  Coverage   91.42%   91.42%           
=======================================
  Files         351      351           
  Lines       21197    21197           
  Branches     2035     2035           
=======================================
  Hits        19380    19380           
  Misses       1260     1260           
  Partials      557      557
Impacted Files Coverage Δ
saleor/graphql/core/types/money.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af9de7c...025efc5. Read the comment docs.

Copy link

django-queries commented Nov 7, 2019

Here is the report for 025efc5 (mirumee/saleor @ deprecate-localized-field-in-money)
Base comparison is af9de7c.

No differences were found. (click me)

# api.benchmark checkout
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  add billing address to checkout            	         34	         34	             20
  add shipping to checkout                   	          7	          7	              0
  checkout payment charge                    	         14	         14	              0
  complete checkout                          	          6	          6	              0
  create checkout                            	         48	         48	             24

# api.benchmark homepage
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  retrieve main menu                         	          5	          5	              0
  retrieve product list                      	          4	          4	              0
  retrieve secondary menu                    	          5	          5	              0
  retrieve shop                              	          2	          2	              0

# api.benchmark product
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  product details                            	         15	         15	              3
  retrieve product attributes                	         13	         13	              2

# api.benchmark variant
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  product variant bulk create                	         51	         51	              3
  retrieve variant list                      	         15	         15	              6

# api product sorting attributes
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  sort product not having attribute data     	         21	         21	              0

…y type

Co-Authored-By: Marcin Gębala <5421321+maarcingebala@users.noreply.github.com>
@maarcingebala maarcingebala merged commit 5cf3050 into master Nov 7, 2019
@maarcingebala maarcingebala deleted the deprecate-localized-field-in-money branch November 7, 2019 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
graphql Issues related to the GraphQL API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate localized field
4 participants