-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add user id to jwt payload #5039
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5039 +/- ##
==========================================
+ Coverage 90.89% 90.89% +<.01%
==========================================
Files 294 294
Lines 18269 18273 +4
Branches 1679 1680 +1
==========================================
+ Hits 16605 16610 +5
+ Misses 1228 1227 -1
Partials 436 436
Continue to review full report at Codecov.
|
Here is the report for 451ebc0 (mirumee/saleor @ add-user-id-to-jwt-payload) No differences were found. (click me)
# api.benchmark checkout
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
add billing address to checkout 34 34 20
add shipping to checkout 7 7 0
checkout payment charge 10 10 0
complete checkout 8 8 0
create checkout 50 50 24
# api.benchmark homepage
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
retrieve main menu 5 5 0
retrieve product list 4 4 0
retrieve secondary menu 5 5 0
retrieve shop 2 2 0
# api.benchmark product
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
product details 15 15 3
retrieve product attributes 9 9 0
# api.benchmark variant
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
product variant bulk create 51 51 3
retrieve variant list 15 15 6
# api product sorting attributes
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
sort product not having attribute data 21 21 0 |
This PR extends JWT payload with additional user global ID to make it easier to use the saleor with other services in a federation, token now contains graphql type key so nothing more is needed to get user data from saleor in a query.
Additionally, it adds email as key to User graphql type as it may be a more convenient identifier.
Pull Request Checklist