Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send fulfillment update email #5118

Merged
merged 4 commits into from
Jan 7, 2020
Merged

Conversation

IKarbowiak
Copy link
Member

Send fulfillment update mail after updating the tracking number in FulfillmentUpdateTracking mutation

Closes #4017

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. Database migration files are up to date.
  6. The changes are tested.
  7. GraphQL schema and type definitions are up to date.
  8. Changes are mentioned in the changelog.

@IKarbowiak IKarbowiak self-assigned this Dec 27, 2019
@IKarbowiak IKarbowiak changed the title Send fulfillment update email in FulfillmentUpdateTracking mutation Send fulfillment update email Dec 27, 2019
@codecov
Copy link

codecov bot commented Dec 27, 2019

Codecov Report

Merging #5118 into master will increase coverage by 0.12%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5118      +/-   ##
==========================================
+ Coverage      91%   91.13%   +0.12%     
==========================================
  Files         259      261       +2     
  Lines       16751    16860     +109     
  Branches     1489     1502      +13     
==========================================
+ Hits        15245    15365     +120     
+ Misses       1103     1094       -9     
+ Partials      403      401       -2
Impacted Files Coverage Δ
saleor/graphql/order/mutations/fulfillments.py 97.91% <100%> (+0.07%) ⬆️
saleor/graphql/payment/schema.py 95.83% <0%> (-4.17%) ⬇️
saleor/graphql/checkout/types.py 95.19% <0%> (-0.81%) ⬇️
saleor/graphql/account/mutations/base.py 98.24% <0%> (-0.42%) ⬇️
saleor/graphql/account/mutations/staff.py 96.7% <0%> (-0.33%) ⬇️
saleor/graphql/checkout/mutations.py 94.05% <0%> (-0.11%) ⬇️
saleor/graphql/checkout/schema.py 100% <0%> (ø) ⬆️
saleor/graphql/page/schema.py 100% <0%> (ø) ⬆️
saleor/graphql/order/schema.py 100% <0%> (ø) ⬆️
saleor/graphql/account/schema.py 100% <0%> (ø) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 187facf...021150c. Read the comment docs.

Copy link

django-queries commented Dec 27, 2019

Here is the report for eec7116 (mirumee/saleor @ send-fulfillment-update-emails)
Base comparison is 9502467.

No differences were found. (click me)

# api.benchmark checkout
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  add billing address to checkout            	         34	         34	             20
  add shipping to checkout                   	          7	          7	              0
  checkout payment charge                    	         10	         10	              0
  complete checkout                          	          8	          8	              0
  create checkout                            	         50	         50	             24

# api.benchmark homepage
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  retrieve main menu                         	          5	          5	              0
  retrieve product list                      	          4	          4	              0
  retrieve secondary menu                    	          5	          5	              0
  retrieve shop                              	          2	          2	              0

# api.benchmark product
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  product details                            	         15	         15	              3
  retrieve product attributes                	          9	          9	              0

# api.benchmark variant
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  product variant bulk create                	         51	         51	              3
  retrieve variant list                      	         15	         15	              6

# api product sorting attributes
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  sort product not having attribute data     	         21	         21	              0

saleor/graphql/order/mutations/fulfillments.py Outdated Show resolved Hide resolved
@maarcingebala maarcingebala merged commit b342d01 into master Jan 7, 2020
@maarcingebala maarcingebala deleted the send-fulfillment-update-emails branch January 7, 2020 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send fulfillment update mail after updating the tracking number
5 participants