-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Account confirmation by email when creating new account #5126
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5126 +/- ##
==========================================
+ Coverage 91.68% 91.68% +<.01%
==========================================
Files 260 260
Lines 16886 16891 +5
Branches 1484 1484
==========================================
+ Hits 15482 15487 +5
Misses 1015 1015
Partials 389 389
Continue to review full report at Codecov.
|
Here is the report for 030defa (mirumee/saleor @ 1527/account_confirmation) No differences were found. (click me)
# api.benchmark checkout
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
add billing address to checkout 34 34 20
add shipping to checkout 7 7 0
checkout payment charge 10 10 0
complete checkout 8 8 0
create checkout 50 50 24
# api.benchmark homepage
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
retrieve main menu 5 5 0
retrieve product list 4 4 0
retrieve secondary menu 5 5 0
retrieve shop 2 2 0
# api.benchmark product
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
product details 14 14 2
retrieve product attributes 9 9 0
# api.benchmark variant
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
product variant bulk create 51 51 3
retrieve variant list 16 16 6
# api product sorting attributes
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
sort product not having attribute data 21 21 0 |
0341808
to
dae99d7
Compare
ef5c97a
to
2cf07ee
Compare
I want to merge this change because it resolves #1527
Cannot be merged until appropriate frontend view is ready (confirmation part that triggers the mutation)
Should also be merged with storefront mutation switch (which can be merged even sooner)
saleor/saleor-storefront#549
Pull Request Checklist