Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account confirmation by email when creating new account #5126

Merged
merged 20 commits into from
Jan 17, 2020

Conversation

tomaszszymanski129
Copy link
Member

@tomaszszymanski129 tomaszszymanski129 commented Jan 2, 2020

I want to merge this change because it resolves #1527
Cannot be merged until appropriate frontend view is ready (confirmation part that triggers the mutation)
Should also be merged with storefront mutation switch (which can be merged even sooner)
saleor/saleor-storefront#549

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. Database migration files are up to date.
  6. The changes are tested.
  7. GraphQL schema and type definitions are up to date.
  8. Changes are mentioned in the changelog.

@codecov
Copy link

codecov bot commented Jan 2, 2020

Codecov Report

Merging #5126 into master will increase coverage by <.01%.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5126      +/-   ##
==========================================
+ Coverage   91.68%   91.68%   +<.01%     
==========================================
  Files         260      260              
  Lines       16886    16891       +5     
  Branches     1484     1484              
==========================================
+ Hits        15482    15487       +5     
  Misses       1015     1015              
  Partials      389      389
Impacted Files Coverage Δ
saleor/graphql/order/schema.py 100% <ø> (ø) ⬆️
saleor/graphql/checkout/types.py 96% <ø> (ø) ⬆️
saleor/payment/gateways/braintree/plugin.py 0% <ø> (ø) ⬆️
saleor/payment/gateways/stripe/__init__.py 98.87% <ø> (ø) ⬆️
saleor/graphql/account/mutations/base.py 98.75% <ø> (ø) ⬆️
saleor/extensions/checks.py 93.93% <ø> (ø) ⬆️
saleor/graphql/order/resolvers.py 84.44% <ø> (ø) ⬆️
saleor/graphql/order/mutations/draft_orders.py 95.71% <ø> (ø) ⬆️
saleor/payment/gateways/stripe/plugin.py 0% <ø> (ø) ⬆️
saleor/wishlist/models.py 88.88% <ø> (ø) ⬆️
... and 105 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53a842b...030defa. Read the comment docs.

Copy link

django-queries commented Jan 2, 2020

Here is the report for 030defa (mirumee/saleor @ 1527/account_confirmation)
Base comparison is 3d8dba3.

No differences were found. (click me)

# api.benchmark checkout
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  add billing address to checkout            	         34	         34	             20
  add shipping to checkout                   	          7	          7	              0
  checkout payment charge                    	         10	         10	              0
  complete checkout                          	          8	          8	              0
  create checkout                            	         50	         50	             24

# api.benchmark homepage
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  retrieve main menu                         	          5	          5	              0
  retrieve product list                      	          4	          4	              0
  retrieve secondary menu                    	          5	          5	              0
  retrieve shop                              	          2	          2	              0

# api.benchmark product
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  product details                            	         14	         14	              2
  retrieve product attributes                	          9	          9	              0

# api.benchmark variant
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  product variant bulk create                	         51	         51	              3
  retrieve variant list                      	         16	         16	              6

# api product sorting attributes
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  sort product not having attribute data     	         21	         21	              0

@tomaszszymanski129 tomaszszymanski129 marked this pull request as ready for review January 9, 2020 13:48
saleor/graphql/account/mutations/account.py Outdated Show resolved Hide resolved
saleor/graphql/account/mutations/base.py Outdated Show resolved Hide resolved
tests/api/test_account.py Outdated Show resolved Hide resolved
saleor/settings.py Outdated Show resolved Hide resolved
@tomaszszymanski129 tomaszszymanski129 removed the request for review from fowczarek January 15, 2020 12:38
saleor/graphql/account/mutations/account.py Outdated Show resolved Hide resolved
saleor/graphql/account/mutations/account.py Outdated Show resolved Hide resolved
saleor/settings.py Show resolved Hide resolved
@maarcingebala maarcingebala merged commit 4837972 into master Jan 17, 2020
@maarcingebala maarcingebala deleted the 1527/account_confirmation branch January 17, 2020 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Newly registered user e-mail confirmation
4 participants