Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sample payload data anonymization #5161

Merged
merged 6 commits into from
Feb 3, 2020

Conversation

derenio
Copy link
Contributor

@derenio derenio commented Jan 13, 2020

This PR adds anonymization to the sample payloads of the GraphQL's webhookSamplePayload endpoint.

  1. The changes are tested.
  2. Changes are mentioned in the changelog.

@derenio derenio requested a review from korycins January 13, 2020 14:06
@derenio derenio self-assigned this Jan 13, 2020
@codecov
Copy link

codecov bot commented Jan 13, 2020

Codecov Report

Merging #5161 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5161   +/-   ##
=======================================
  Coverage   91.81%   91.81%           
=======================================
  Files         271      271           
  Lines       17589    17589           
  Branches     1525     1525           
=======================================
  Hits        16149    16149           
  Misses       1041     1041           
  Partials      399      399

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac00ec1...b1e96d1. Read the comment docs.

Copy link

django-queries commented Jan 13, 2020

Here is the report for ac00ec1 (mirumee/saleor @ feature/anonymize_sample_payloads)
Base comparison is 9dfd1bc.

No differences were found. (click me)

# api.benchmark checkout
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  add billing address to checkout            	         34	         34	             20
  add shipping to checkout                   	          7	          7	              0
  checkout payment charge                    	         10	         10	              0
  complete checkout                          	          8	          8	              0
  create checkout                            	          5	          5	              1

# api.benchmark homepage
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  retrieve main menu                         	          5	          5	              0
  retrieve product list                      	          4	          4	              0
  retrieve secondary menu                    	          5	          5	              0
  retrieve shop                              	          2	          2	              0

# api.benchmark product
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  product details                            	         18	         18	              4
  retrieve product attributes                	          9	          9	              0

# api.benchmark variant
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  product variant bulk create                	         51	         51	              3
  retrieve variant list                      	         23	         23	              9

# api product sorting attributes
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  sort product not having attribute data     	         21	         21	              0

@maarcingebala maarcingebala merged commit 61b3a62 into master Feb 3, 2020
@maarcingebala maarcingebala deleted the feature/anonymize_sample_payloads branch February 3, 2020 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants