-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require fields in schema #5293
Require fields in schema #5293
Conversation
Here is the report for 9d90e4b (mirumee/saleor @ fix/require-fields) No differences were found. (click me)
# api.benchmark category
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
category view 23 23 0
# api.benchmark checkout
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
add billing address to checkout 34 34 20
add shipping to checkout 7 7 0
checkout payment charge 10 10 0
complete checkout 8 8 0
create checkout 5 5 1
# api.benchmark collection
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
collection view 21 21 0
# api.benchmark homepage
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
featured products list 20 20 0
retrieve main menu 8 8 0
retrieve product list 6 6 0
retrieve secondary menu 8 8 0
retrieve shop 2 2 0
user checkout details 53 53 28
# api.benchmark product
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
product details 17 17 3
retrieve product attributes 9 9 0
# api.benchmark variant
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
product variant bulk create 51 51 3
retrieve variant list 23 23 9
# api product sorting attributes
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
sort product not having attribute data 21 21 0 |
Codecov Report
@@ Coverage Diff @@
## master #5293 +/- ##
==========================================
+ Coverage 91.59% 91.59% +<.01%
==========================================
Files 283 283
Lines 18181 18182 +1
Branches 1581 1581
==========================================
+ Hits 16653 16654 +1
Misses 1105 1105
Partials 423 423
Continue to review full report at Codecov.
|
@dominik-zeglen the schema is out of date apparently |
f1124bf
to
9d90e4b
Compare
I want to merge this change because it ensures API consumer that these fields are always returned and non-nullable.
Pull Request Checklist