-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add product price validation #5413
Add product price validation #5413
Conversation
57e44ca
to
75e87f7
Compare
Codecov Report
@@ Coverage Diff @@
## master #5413 +/- ##
==========================================
- Coverage 91.13% 91.11% -0.02%
==========================================
Files 283 283
Lines 18329 18343 +14
Branches 1608 1613 +5
==========================================
+ Hits 16704 16714 +10
- Misses 1196 1200 +4
Partials 429 429
Continue to review full report at Codecov.
|
75e87f7
to
0b2b447
Compare
@kswiatek92 There are a few more places where we can set prices in API. We have
We should ensure that we have validation there as well. If it makes sense maybe we should add a function that does this validation and raises this error so don't have to duplicate entire ValidationError multiple times. |
@maarcingebala I don't think it's necessary, |
6aed1ee
to
db075e1
Compare
db075e1
to
71a2d52
Compare
@kswiatek92 @maarcingebala What do you think about introducing a specific error code for this validation? |
36119c4
to
1933e6b
Compare
1933e6b
to
a137441
Compare
closes #5326
Pull Request Checklist