Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send a confirmation email when the order is canceled or refunded #6017

Merged
merged 7 commits into from
Aug 18, 2020

Conversation

IKarbowiak
Copy link
Member

@IKarbowiak IKarbowiak commented Aug 17, 2020

Send a confirmation email when the order is canceled or refunded.

Impact

  • New migrations
  • New/Updated API fields or mutations
  • Deprecated API fields or mutations
  • Removed API types, fields, or mutations
  • Documentation needs to be updated

Pull Request Checklist

  • Privileged queries and mutations are guarded by proper permission checks
  • Database queries are optimized and the number of queries is constant
  • Database migration files are up to date
  • The changes are tested
  • GraphQL schema and type definitions are up to date
  • Changes are mentioned in the changelog

@github-actions github-actions bot temporarily deployed to add-emails-for-refund-and-cancel-order August 17, 2020 11:25 Inactive
@IKarbowiak IKarbowiak changed the title Add emails for refund and cancel order Send a confirmation email when the order is canceled or refunded. Aug 17, 2020
@IKarbowiak IKarbowiak changed the title Send a confirmation email when the order is canceled or refunded. Send a confirmation email when the order is canceled or refunded Aug 17, 2020
@IKarbowiak IKarbowiak force-pushed the add-emails-for-refund-and-cancel-order branch from 970a965 to 4c7bbd6 Compare August 17, 2020 11:28
@github-actions github-actions bot temporarily deployed to add-emails-for-refund-and-cancel-order August 17, 2020 11:29 Inactive
@codecov
Copy link

codecov bot commented Aug 17, 2020

Codecov Report

Merging #6017 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6017   +/-   ##
=======================================
  Coverage   91.57%   91.58%           
=======================================
  Files         387      387           
  Lines       25237    25260   +23     
  Branches     2367     2367           
=======================================
+ Hits        23112    23135   +23     
  Misses       1547     1547           
  Partials      578      578           
Impacted Files Coverage Δ
saleor/order/__init__.py 100.00% <100.00%> (ø)
saleor/order/actions.py 94.83% <100.00%> (+0.06%) ⬆️
saleor/order/emails.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa27fad...4c7bbd6. Read the comment docs.

@db-queries
Copy link

db-queries bot commented Aug 17, 2020

Here is the report for 4c7bbd6 (mirumee/saleor @ add-emails-for-refund-and-cancel-order)
Base comparison is fa27fad.

No differences were found. (click me)

# saleor.graphql.accountbenchmark account
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
  delete staff members                                       	         32	         32	              0
  query staff user                                           	         20	         20	              4
  staff create                                               	         22	         22	              4
  staff update groups and permissions                        	         33	         33	              5

# saleor.graphql.accountbenchmark permission group
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
  permission group create                                    	         19	         19	              2
  permission group delete                                    	         20	         20	              3
  permission group query                                     	          7	          7	              0
  permission group update                                    	         33	         33	              1
  permission group update remove users with manage staff     	         27	         27	              3

# saleor.graphql.checkoutbenchmark checkout mutations
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
  add billing address to checkout                            	         50	         50	             26
  add shipping to checkout                                   	         37	         37	             11
  checkout email update                                      	         28	         28	             13
  checkout payment charge                                    	         30	         30	              8
  checkout shipping address update                           	         39	         39	             11
  checkout voucher code                                      	         57	         57	             31
  complete checkout                                          	         91	         91	             26
  create checkout                                            	        125	        125	             60
  update checkout lines                                      	         92	         92	             40

# saleor.graphql.checkoutbenchmark homepage
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
  user checkout details                                      	         50	         50	             27

# saleor.graphql.menubenchmark homepage
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
  retrieve main menu                                         	          5	          5	              0
  retrieve secondary menu                                    	          5	          5	              0

# saleor.graphql.orderbenchmark order
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
  user order details                                         	         17	         17	              3

# saleor.graphql.productbenchmark category
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
  category view                                              	         18	         18	              1

# saleor.graphql.productbenchmark collection
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
  collection view                                            	         17	         17	              0

# saleor.graphql.productbenchmark homepage
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
  featured products list                                     	         14	         14	              0
  retrieve product list                                      	          5	          5	              0

# saleor.graphql.productbenchmark product
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
  product details                                            	         16	         16	              0
  retrieve product attributes                                	          7	          7	              0

# saleor.graphql.productbenchmark variant
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
  product variant bulk create                                	         47	         47	              2
  retrieve variant list                                      	         18	         18	              2

# saleor.graphql.productbenchmark variant stocks
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
  product variants stocks create                             	         22	         22	              5
  product variants stocks delete                             	         19	         19	              5
  product variants stocks update                             	         27	         27	              5

# saleor.graphql.producttest product sorting attributes
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
  sort product not having attribute data                     	         20	         20	              0

# saleor.graphql.shopbenchmark homepage
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
  retrieve shop                                              	          2	          2	              0

saleor/order/actions.py Show resolved Hide resolved
saleor/order/emails.py Show resolved Hide resolved
@maarcingebala maarcingebala merged commit 2bd85e7 into master Aug 18, 2020
@maarcingebala maarcingebala deleted the add-emails-for-refund-and-cancel-order branch August 18, 2020 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants