[WIP] Move left navigation construction out of the template #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is ok for testing now, it appears to work as intended. |
|
Tested fully on Sandbox. One issue with the menus was identified not displaying child pages which has now been rectified. Tested fully down to 4 levels of sub pages and also three levels of sub pages when using the context module. |
JeebsUK
added a commit
that referenced
this pull request
Mar 28, 2014
[WIP] Move left navigation construction out of the template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current way of constructing the left-hand navigation doesn't always work correctly (see #9 and #11). This change uses the entire menu and then changes it to the structure that we need. Since Drupal has found the items to show (rather than trying to work them out), it then removes the problems (and so fixes #9).
It also handles potential sub menus better (it recognises 'Home' links and handles them appropriately).
(This is a work in progress and isn't ready to be merged.)