Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed parseEntity regex to remove Catastrophic Backtracking #62

Closed
wants to merge 1 commit into from

Conversation

bstoney
Copy link

@bstoney bstoney commented Mar 10, 2016

this fixes #61

@bstoney
Copy link
Author

bstoney commented Mar 10, 2016

Any idea about why the test failed? I have rerun all the tests locally with both php 5.6 and 7.0 (7.0.2) and everything looks good. I have not had much experience with travis or AppVeyor, so might need some guidance to figure out the issue.

@bstoney
Copy link
Author

bstoney commented Mar 10, 2016

I've retested after after updating to php 7.0.4 and it is failing. Looks like there has been a change to php unserialize since php 7.0.2 which is breaking this. php/php-src@bcd64a9 I'll look into it a bit more and see if those changes are causing the problem

@mishal
Copy link
Owner

mishal commented Mar 11, 2016

Thanks for the PR. I have few points:

  • please do not touch the test files from less.js (tests/ILess/Test/Parser/_fixtures/less.js/) - they are copied from the less.js project and used for compatibility comparison
  • create a test case in Issues directory for this issue

I'm not sure what is the problem with serialize under PHP7, I don't have access to it.

@mishal
Copy link
Owner

mishal commented Mar 11, 2016

Your fix is not the cause of the problem.
I restared old build and it failed under php 7:
https://travis-ci.org/mishal/iless/jobs/86137704

@mishal
Copy link
Owner

mishal commented Mar 11, 2016

The problematic is import-reference.less with cache enabled. I will create separate issue for this.

@bstoney
Copy link
Author

bstoney commented Mar 11, 2016

Ok thanks. I'll revert the css file and add in a new test case in my fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

parser fails with error code for long data uri
2 participants