Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove client secret as required constructor argument #11

Closed
maks opened this issue Feb 1, 2022 · 0 comments · Fixed by #12
Closed

remove client secret as required constructor argument #11

maks opened this issue Feb 1, 2022 · 0 comments · Fixed by #12

Comments

@maks
Copy link
Contributor

maks commented Feb 1, 2022

Auth0 recommends that the client secret never be stored in a mobile app.

The current constructor api has the client secret as a required named parameter, but its actually only used in passwordGrant() and I'm not actually sure if it's even needed there?

It would be a good to remove the client secret from the constructor and only have it passed in as a parameter to passwordGrant() to make it clear to users of this package that it is not a good practise to store the secret in a mobile app nor is it required for most (all?) the end point used by this package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant