remove secret from cons, add as passwordGrant arg #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't changed the version in the pubspec in this PR but given this is a breaking API change, I would assume that the major version number would need to be bumped. |
|
@maks Are you sure secret is required ONLY for passwordGrant? |
|
@mishatron yes I think so, as |
|
@maks look at 2.2.0-beta1 |
|
@mishatron thank you for looking at the PR, merging and publishing a new version so quickly! very much appreciated 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the client secret parameter from the constructor and makes it a parameter to the only method that currently uses it.
If
passwordGrant()doesn't end up needing it either then it should be removed altogether in a future PR.Fixes: #11