This repository has been archived by the owner on Jun 10, 2024. It is now read-only.
Fixes Location plugin edition after adding to map #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mishbahr
reviewed
Apr 9, 2018
djangocms_gmaps/cms_plugins.py
Outdated
| @@ -21,8 +21,9 @@ class LocationPlugin(CMSPluginBase): | |||
| form = LocationForm | |||
| module = settings.DJANGOCMS_GMAPS_PLUGIN_MODULE | |||
| name = settings.DJANGOCMS_GMAPS_LOCATION_PLUGIN_NAME | |||
| render_plugin = False | |||
| render_plugin = True | |||
There was a problem hiding this comment.
render_plugin by default is set to True
|
I haven't used django-cms for over 2 years now. Is there a better solution than having to add an empty template? Also we probably should set |
|
Right, my bad! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refers to issue #8 where Location edition becomes impossible after adding a Location to a map.
Kudos to @lmanzurv for finding this solution. All suggestions are welcome