Skip to content

Commit

Permalink
fix corner case in ie (#5372)
Browse files Browse the repository at this point in the history
fixes #5370
  • Loading branch information
alexlamsl committed Mar 2, 2022
1 parent fdbbef2 commit 104d385
Show file tree
Hide file tree
Showing 3 changed files with 49 additions and 1 deletion.
2 changes: 1 addition & 1 deletion lib/scope.js
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ AST_Toplevel.DEFMETHOD("figure_out_scope", function(options) {
defun.def_variable(node);
} else if (node instanceof AST_SymbolLambda) {
var def = defun.def_function(node, node.name == "arguments" ? undefined : defun);
if (options.ie) def.defun = defun.parent_scope.resolve();
if (options.ie && node.name != "arguments") def.defun = defun.parent_scope.resolve();
} else if (node instanceof AST_SymbolLet) {
var def = scope.def_variable(node);
if (exported) def.exported = true;
Expand Down
24 changes: 24 additions & 0 deletions test/compress/destructured.js
Original file line number Diff line number Diff line change
Expand Up @@ -3473,3 +3473,27 @@ issue_5314_2: {
expect_stdout: "PASS"
node_version: ">=6"
}

issue_5370: {
options = {
dead_code: true,
ie: true,
unused: true,
}
input: {
console.log(function arguments({}) {
return arguments;
try {} catch (e) {
var arguments;
}
}(42));
}
expect: {
console.log(function arguments({}) {
return arguments;
var arguments;
}(42));
}
expect_stdout: true
node_version: ">=6"
}
24 changes: 24 additions & 0 deletions test/compress/rests.js
Original file line number Diff line number Diff line change
Expand Up @@ -1299,3 +1299,27 @@ issue_5360: {
expect_stdout: "PASS"
node_version: ">=8.3.0"
}

issue_5370: {
options = {
dead_code: true,
ie: true,
unused: true,
}
input: {
console.log(function arguments(...a) {
return arguments;
try {} catch (e) {
var arguments;
}
}());
}
expect: {
console.log(function arguments(...a) {
return arguments;
var arguments;
}());
}
expect_stdout: true
node_version: ">=6"
}

0 comments on commit 104d385

Please sign in to comment.