fix corner case in join_vars (#5176)

fixes #5175
mishoo · Nov 15, 2021 · 77f7ae5 · 77f7ae5
1 parent 2d0f8bc
commit 77f7ae5
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 1 deletion.
diff --git a/lib/compress.js b/lib/compress.js
@@ -3500,7 +3500,7 @@ merge(Compressor.prototype, {
             var exprs = extract_exprs(body);
             if (!exprs) return;
             var trimmed = false;
-            for (var i = exprs.length; --i >= 0;) {
+            for (var i = exprs.length - (keep || 0); --i >= 0;) {
                 var expr = exprs[i];
                 if (!can_trim(expr)) continue;
                 var tail;

diff --git a/test/compress/join_vars.js b/test/compress/join_vars.js
@@ -1293,3 +1293,26 @@ assign_sequence_var: {
         "1 2 3",
     ]
 }
+
+issue_5175: {
+    options = {
+        join_vars: true,
+    }
+    input: {
+        function log(f) {
+            console.log(f(), A.p);
+        }
+        log(function() {
+            return (A = {}).p = "PASS";
+        });
+    }
+    expect: {
+        function log(f) {
+            console.log(f(), A.p);
+        }
+        log(function() {
+            return (A = {}).p = "PASS";
+        });
+    }
+    expect_stdout: "PASS PASS"
+}