fix corner case in reduce_vars (#3881)

fixes #3880
mishoo · May 11, 2020 · e8a7956 · e8a7956
1 parent 2b24dc2
commit e8a7956
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 2 deletions.
diff --git a/lib/compress.js b/lib/compress.js
@@ -797,8 +797,12 @@ merge(Compressor.prototype, {
                     d.recursive_refs++;
                 } else if (value && ref_once(tw, compressor, d)) {
                     d.in_loop = tw.loop_ids[d.id] !== tw.in_loop;
-                    d.single_use = value instanceof AST_Lambda && !value.pinned()
-                        || !d.in_loop && d.scope === this.scope && value.is_constant_expression();
+                    d.single_use = value instanceof AST_Lambda
+                            && !value.pinned()
+                            && (!d.in_loop || tw.parent() instanceof AST_Call)
+                        || !d.in_loop
+                            && d.scope === this.scope
+                            && value.is_constant_expression();
                 } else {
                     d.single_use = false;
                 }

diff --git a/test/compress/reduce_vars.js b/test/compress/reduce_vars.js
@@ -7047,3 +7047,24 @@ issue_3866: {
     }
     expect_stdout: "PASS"
 }
+
+issue_3880: {
+    options = {
+        reduce_funcs: true,
+        reduce_vars: true,
+        unused: true,
+    }
+    input: {
+        (function(a) {
+            while (a.var ^= 1);
+            console.log("PASS");
+        })(function() {});
+    }
+    expect: {
+        (function(a) {
+            while (a.var ^= 1);
+            console.log("PASS");
+        })(function() {});
+    }
+    expect_stdout: "PASS"
+}