fix corner case in hoist_vars (#5188)

fixes #5187
mishoo · Nov 23, 2021 · ea10498 · ea10498
1 parent 69636da
commit ea10498
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 2 deletions.
diff --git a/lib/compress.js b/lib/compress.js
@@ -9071,10 +9071,13 @@ merge(Compressor.prototype, {
                     right: value,
                 });
                 a.push(assign);
-                name.fixed = function() {
+                var fixed = function() {
                     return assign.right;
                 };
-                name.fixed.assigns = [ assign ];
+                fixed.assigns = [ assign ];
+                fixed.direct_access = def.direct_access;
+                fixed.escaped = def.escaped;
+                name.fixed = fixed;
                 def.references.forEach(function(ref) {
                     var assigns = ref.fixed && ref.fixed.assigns;
                     if (assigns && assigns[0] === defn) assigns[0] = assign;

diff --git a/test/compress/hoist_vars.js b/test/compress/hoist_vars.js
@@ -418,3 +418,32 @@ issue_4898: {
     }
     expect_stdout: "PASS"
 }
+
+issue_5187: {
+    options = {
+        hoist_props: true,
+        hoist_vars: true,
+        reduce_vars: true,
+        side_effects: true,
+        toplevel: true,
+        unused: true,
+    }
+    input: {
+        function f() {
+            var a = 42;
+            do {
+                var b = { 0: a++ };
+            } while (console.log(b[b ^= 0]));
+        }
+        f();
+    }
+    expect: {
+        (function() {
+            var b, a = 42;
+            do {
+                b = { 0: a++ };
+            } while (console.log(b[b ^= 0]));
+        })();
+    }
+    expect_stdout: "42"
+}