Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox error's stack trace is unable to read Source Maps when output code is minified #3023

Closed
kamilogorek opened this issue Mar 23, 2018 · 4 comments · Fixed by #3030
Closed

Comments

@kamilogorek
Copy link

Repost from webpack-contrib/uglifyjs-webpack-plugin#266 as it's more appropriate to live here.

Working solution by @kzc available here webpack-contrib/uglifyjs-webpack-plugin#266 (comment)

@alexlamsl
Copy link
Collaborator

Please follow the issue template and provide useful information for this project in the future.

Closing as duplicate of #968

@kzc
Copy link
Contributor

kzc commented Mar 23, 2018

It's a source map issue for array and object literals unrelated to #968.

@alexlamsl
Copy link
Collaborator

@kzc I see - but this issue only affects harmony, right?

@kzc
Copy link
Contributor

kzc commented Mar 23, 2018

but this issue only affects harmony, right?

It happened to be discovered with uglify-es, but is equally applicable to master as well. Just remove the AST_Class from the patch and verify the resultant source map with https://sokra.github.io/source-map-visualization/

@alexlamsl alexlamsl removed the harmony label Mar 23, 2018
alexlamsl added a commit to alexlamsl/UglifyJS that referenced this issue Mar 29, 2018
alexlamsl added a commit to alexlamsl/UglifyJS that referenced this issue Mar 29, 2018
alexlamsl added a commit that referenced this issue Mar 29, 2018
alexlamsl added a commit to alexlamsl/UglifyJS that referenced this issue Mar 29, 2018
alexlamsl added a commit that referenced this issue Mar 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants