Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add W3C standard Custom Elements to /tools/domprops.json #3037

Closed
Danny-Engelman opened this issue Mar 30, 2018 · 2 comments · Fixed by #3369
Closed

Add W3C standard Custom Elements to /tools/domprops.json #3037

Danny-Engelman opened this issue Mar 30, 2018 · 2 comments · Fixed by #3369

Comments

@Danny-Engelman
Copy link

Danny-Engelman commented Mar 30, 2018

enhancement

Add standard W3C Custom Elements to /tools/domprops.json, so they do not get mangled

"customElements", "define", "observedAttributes", "attributeChangedCallback", "connectedCallback", "isConnected", "disconnectedCallback", "adoptedCallback"

https://html.spec.whatwg.org/multipage/custom-elements.html#custom-elements

@alexlamsl
Copy link
Collaborator

This is similar to #2343 in that someone needs to put together a Pull Request after running tools/props.html on a list of web browsers to update the list of keywords to avoid.

@Danny-Engelman
Copy link
Author

props.html does not pick up most of these (Chrome 65)

So I presume they will be erased again when someone PRs props.html output

I have added them to my uglify-config.json to be sure:

  "mangle": {
    "reserved": [
      "customElements",
      "define",
      "observedAttributes",
      "attributeChangedCallback",
      "connectedCallback",
      "isConnected",
      "disconnectedCallback",
      "adoptedCallback"
    ],

alexlamsl added a commit to alexlamsl/UglifyJS that referenced this issue Apr 19, 2019
alexlamsl added a commit that referenced this issue Apr 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants