Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] opportunistically turn assignment into declaration #1821

Closed
wants to merge 1 commit into from

Conversation

alexlamsl
Copy link
Collaborator

fixes #27
fixes #315

@kzc kzc mentioned this pull request Apr 18, 2017
@kzc
Copy link
Contributor

kzc commented Apr 18, 2017

Will this PR proceed in addition to #1829? This PR has the advantage of working with pass=1.

@alexlamsl
Copy link
Collaborator Author

Except it turns out to be too aggressive in its replacement behaviour, which is why many of the other PRs are spawned instead.

This PR will proceed eventually - at least I have an updated idea on how it should work after #1828.

The cycle has been:

  1. try and get this PR to work
  2. keep patching up things to force my way through
  3. hit brick wall
  4. separate patches from Step 2 into new PRs
  5. goto Step 1

@kzc
Copy link
Contributor

kzc commented Apr 18, 2017

Sounds like a good plan of attack.

@alexlamsl
Copy link
Collaborator Author

I think 65a7d92 is still not the correct approach, but at least it's getter closer now.

alexlamsl added a commit to alexlamsl/UglifyJS that referenced this pull request May 3, 2017
@alexlamsl alexlamsl closed this in dee5a27 May 6, 2017
@alexlamsl alexlamsl deleted the assign-var branch May 6, 2017 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compression of CoffeeScript output Unnecesary variable definitions not being removed
2 participants