Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add documentation for commit 1e51586 #1925

Merged
merged 1 commit into from May 12, 2017

Conversation

olsonpm
Copy link
Contributor

@olsonpm olsonpm commented May 12, 2017

Wasn't sure if the documentation was purposefully left out. Feel free to close if so.

@alexlamsl
Copy link
Collaborator

@olsonpm thanks for the patch - I'm surprised side_effects wasn't documented.

@alexlamsl alexlamsl merged commit 547f41b into mishoo:master May 12, 2017
@olsonpm
Copy link
Contributor Author

olsonpm commented May 12, 2017

I'm messing with that functionality right now trying to get it to work well with ramda. You and kzc are so busy updating this lib - I can't thank you guys enough.

alexlamsl pushed a commit to alexlamsl/UglifyJS that referenced this pull request May 12, 2017
@kzc
Copy link
Contributor

kzc commented May 12, 2017

@olsonpm Thanks!

@alexlamsl
Copy link
Collaborator

Backporting to v2.x as well since it's equally applicable there.

@olsonpm olsonpm deleted the add-compressor-option-side_effects branch May 12, 2017 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants