fix parsing of property access after new line #1944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsmepetrov
approved these changes
May 15, 2017
isnifer
approved these changes
May 15, 2017
|
@alexlamsl So now we know what the original parse code was for. :-) |
Heh. Except I think that is a workaround for the deficancies of |
Account for comments when detecting property access in `tokenizer`. fixes mishoo#1943
|
@alexlamsl can you also ship this fix for 2.x version? |
|
@itsmepetrov this will be backported to |
|
@alexlamsl good) Can you push the new version to npm? |
|
We still release 2.x versions of Will probably take a hour or so while Travis CI verifies everything though. |
|
Ok, thanks 👍 |
alexlamsl
added a commit
to alexlamsl/UglifyJS
that referenced
this pull request
May 15, 2017
Account for comments when detecting property access in `tokenizer`. fixes mishoo#1943
This was referenced May 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Account for comments when detecting property access in
tokenizer.fixes #1943