-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] update output options in readme #1958
Conversation
README.md
Outdated
comments, `"some"` to preserve some comments, a regular expression string | ||
(e.g. `/^!/`) or a function. | ||
- `ie8` (default `false`) -- pass `true` to support non-standard Internet | ||
Explorer 8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove ie8
here as suggested in #1957 (comment)
Users should be using options.ie8
under https://github.com/mishoo/UglifyJS2#minify-options
README.md
Outdated
semicolon, leading to more readable output of uglified code (size before | ||
gzip could be smaller; size after gzip insignificantly larger). | ||
- `shebang` (default `true`) -- preserve shebang `#!` in preamble (bash scripts) | ||
- `source_map` (default `null`) -- pass a `SourceMap` object to generate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
options.output.source_map
is an internal flag used by options.sourceMap
, thus no need to be documented.
@Mottie thanks for the work 👍 Looks fine to me except for the two comments above. |
Please don't document
I think the code for it should be dropped. |
#54 is part of the reason why I'll put together a PR to remove |
Updated. |
@Mottie LGTM - thanks! |
@alexlamsl Should we drop
Edit: in |
@kzc I have no idea why May I investigate further then put together a PR to tackle that instead of blocking this PR? |
It's your call as the maintainer but I think this PR should remove |
Be aware that README commits are instantaneously shown on github and are independent of releases. |
@Mottie thanks for (literally) sorting this! |
Fix for PR #1957
beautify
,inline_script
andmax_line_len
.comments
,ie8
,preserve_line
,shebang
,source_map
,unescape_regexps
andwrap_iife
.