fix hoist_funs on block-scoped function under "use strict"
#2013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technically not part of ES5, but commonly used code exists in the wild.
kzc
reviewed
May 27, 2017
lib/compress.js
Outdated
| @@ -2251,7 +2251,8 @@ merge(Compressor.prototype, { | |||
| dirs.push(node); | |||
| return make_node(AST_EmptyStatement, node); | |||
| } | |||
| if (node instanceof AST_Defun && hoist_funs) { | |||
| if (node instanceof AST_Defun && hoist_funs | |||
| && (tt.parent() === self || !compressor.has_directive("use strict"))) { | |||
There was a problem hiding this comment.
instanceof is more than 10X slower than a boolean variable check, so could you put the hoist_funs condition first?
I appreciate this would only help the case when hoist_funs is disabled, but it also makes the code clearer.
There was a problem hiding this comment.
I debated with myself a bit over this performance vs. minimal change thing, but I'll take your vote now that you've casted it 😉
|
I see. There's a method to your madness! |
|
This PR should help to reduce false positives in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technically not part of ES5, but commonly used code exists in the wild.
@kzc this should directly address #1953 (comment)