-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable hoist_props
by default
#2492
Conversation
|
LGTM It has a small but positive effect here, but it will make more of an impact on scope hoisting bundlers. |
Should the readme be updated too? |
--- a/README.md
+++ b/README.md
@@ -635 +635 @@ If you're using the `X-SourceMap` header instead, you can just omit `sourceMap.u
-- `hoist_props` (default: `false`) -- hoist properties from constant object and
+- `hoist_props` (default: `true`) -- hoist properties from constant object and |
880c2b9
to
22bf837
Compare
Thanks - |
option is disabled. Does not negatively impact other major browsers. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The github builtin editor appears to add those trailing spaces.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not to worry - VSCode will pick up the slack 😉
/cc @kzc