handle pure_funcs under inline & reduce_vars correctly
#3066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfaproject
reviewed
Apr 9, 2018
| @@ -685,7 +685,8 @@ If you're using the `X-SourceMap` header instead, you can just omit `sourceMap.u | |||
| pass `pure_funcs: [ 'Math.floor' ]` to let it know that this | |||
| function won't produce any side effect, in which case the whole | |||
| statement would get discarded. The current implementation adds some | |||
| overhead (compression will be slower). | |||
| overhead (compression will be slower). Make sure symbols under `pure_funcs` | |||
| are also under `mangle.reserved` to avoid mangling. | |||
There was a problem hiding this comment.
Too much hassle to maintain for a non-default feature.
There was a problem hiding this comment.
This is actually a regression from 2.x. The pure_funcs used to work correctly without mangle.reserved:
Further, unlike mangle.reserved, you will notice in the link that the retained pure_funcs were also mangled after they were processed in 2.x as one would expect.
If you want to correct the comment above just erase the note about using mangle.reserved and say to use --no-rename as a workaround in 3.x when mangling with pure_funcs. Alternatively, the specified pure_funcs could be excluded in the rename pass. Or simpler still the rename pass could just be disabled automatically when pure_funcs is specified.
kzc
referenced
this pull request
in terser/terser
May 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3065