Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix corner case in conditionals #3577

Merged
merged 1 commit into from
Nov 8, 2019
Merged

Conversation

alexlamsl
Copy link
Collaborator

fixes #3576

@alexlamsl alexlamsl merged commit 5045e14 into mishoo:master Nov 8, 2019
@alexlamsl alexlamsl deleted the issue-3576 branch November 8, 2019 16:53
@kzc
Copy link
Contributor

kzc commented Nov 9, 2019

Wow, this is an old one - from v3.0.0. I'll never cease to be amazed by what the fuzzer continues to find.

What's the MFuzz/day throughput now?

Did GitHub ever fix their Actions failure timeout issue or did you find a workaround?

@alexlamsl
Copy link
Collaborator Author

Yup, pretty happy with ufuzz thus far.

We are currently looking at ~3MFuzz per day.

That hours-long time-out issue is still there, making those job errors caused by connection resets that much more painful. Hopefully once they fixed the cache action enough that would be less of a PITA...

@alexlamsl
Copy link
Collaborator Author

Speaking of ufuzz, this false positive is quite a beauty 😉

https://github.com/alexlamsl/UglifyJS2/runs/295871559#step:3:64

@kzc
Copy link
Contributor

kzc commented Nov 10, 2019

That's a good one.

$ echo 'for(var k in this){a=this[k]} console.log(a); var a=42;' | node
k

$ echo 'var a=42; for(var k in this){a=this[k]} console.log(a); var u;' | node
undefined

$ echo 'var u; var a=42; for(var k in this){a=this[k]} console.log(a);' | node
k

Who needs crossword puzzles when you can reduce fuzzer test cases?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ufuzz failure
2 participants