refine precision limits on unsafe_math
#3589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That should significantly reduce the number of false positives of unsafe_math fuzzing. Perhaps some of those fuzzing checks can be removed. |
kzc
reviewed
Nov 16, 2019
| unsafe_math: true, | ||
| } | ||
| input: { | ||
| console.log(4 / -3 + 1 === 1 / -3); |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
It's just a simplified version of #3587 (comment) 馃槈
Heh, those extra logic in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3587 (comment)
@kzc the original rationale for picking
20as the limits instead is due to this:Obviously your suggestion makes better sense 馃槈
(TIL https://en.wikipedia.org/wiki/Significand#Use_of_%22mantissa%22)