Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep single line comments after nlb, after nlb #608

Closed
wants to merge 1 commit into from

Conversation

avdg
Copy link
Contributor

@avdg avdg commented Jan 9, 2015

Fixes #583

@rvanvelzen
Copy link
Collaborator

Could you perhaps elaborate on why you feel this is the right solution?

@avdg
Copy link
Contributor Author

avdg commented Jan 10, 2015

Sure,

  • By keeping lines with only single line comments, there is no need to search for comments after a long line of code. Also it doesn't break with comment readers if those are involved. If this isn't wanted, the whole pr can be aborted
  • Do this only when beautify option is disabled: it's already formatted
  • This shouldn't affect size and compression a lot since only a few more "\n" characters are inserted.
  • By default, no comments are displayed anyway, so it doesn't harm compressed code with default options anyway.

@rvanvelzen
Copy link
Collaborator

Thanks! Merged as 099992e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uglified code breaks Greasemonkey scripts
2 participants