Skip to content

Commit

Permalink
fix parsing of property access after new line (#1944)
Browse files Browse the repository at this point in the history
Account for comments when detecting property access in `tokenizer`.

fixes #1943
  • Loading branch information
alexlamsl committed May 15, 2017
1 parent ecb63ad commit 6cd580d
Show file tree
Hide file tree
Showing 2 changed files with 36 additions and 1 deletion.
6 changes: 5 additions & 1 deletion lib/parse.js
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,11 @@ function tokenizer($TEXT, filename, html5_comments, shebang) {
S.regex_allowed = ((type == "operator" && !UNARY_POSTFIX(value)) ||
(type == "keyword" && KEYWORDS_BEFORE_EXPRESSION(value)) ||
(type == "punc" && PUNC_BEFORE_EXPRESSION(value)));
prev_was_dot = (type == "punc" && value == ".");
if (type == "punc" && value == ".") {
prev_was_dot = true;
} else if (!is_comment) {
prev_was_dot = false;
}
var ret = {
type : type,
value : value,
Expand Down
31 changes: 31 additions & 0 deletions test/compress/issue-1943.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
operator: {
input: {
a. //comment
typeof
}
expect_exact: "a.typeof;"
}

name: {
input: {
a. //comment
b
}
expect_exact: "a.b;"
}

keyword: {
input: {
a. //comment
default
}
expect_exact: "a.default;"
}

atom: {
input: {
a. //comment
true
}
expect_exact: "a.true;"
}

0 comments on commit 6cd580d

Please sign in to comment.